Slirp: Remove for Podman6 #27338
Draft
Slirp: Remove for Podman6 #27338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
release-note
do-not-merge/work-in-progress
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lsm5 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
github-actions
bot
added
the
kind/api-change
lsm5
added
No New Tests
openshift-merge-robot
added
the
needs-rebase
lsm5
force-pushed
the
podman6-no-slirp
branch
from
3f540c7 to
846a13c
Compare
openshift-merge-robot
removed
the
needs-rebase
github-actions
bot
added
needs-rebase
lsm5
force-pushed
the
podman6-no-slirp
branch
from
846a13c to
218b398
Compare
openshift-merge-robot
removed
the
needs-rebase
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
1 similar comment
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
lsm5
force-pushed
the
podman6-no-slirp
branch
2 times, most recently
from
583764c to
d7744ec
Compare
|
Yeah, that sounds like a genuine problem on the podman side: |
lsm5
force-pushed
the
podman6-no-slirp
branch
from
d7744ec to
a55c778
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
a55c778 to
f36cb63
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
f36cb63 to
2e7738c
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
d9d63e6 to
42f95ad
Compare
lsm5
force-pushed
the
podman6-no-slirp
branch
from
6057111 to
9dbfe03
Compare
|
[NON-BLOCKING] Packit jobs failed. @containers/packit-build please check. Everyone else, feel free to ignore. |
lsm5
force-pushed
the
podman6-no-slirp
branch
2 times, most recently
from
41ea257 to
b2624c3
Compare
This will fetch latest dependencies from podman-next while using podman from the packit copr builds. TMT_TREE envvar is ok to use in this case as it will only be used on upstream packit tests. Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
Signed-off-by: Lokesh Mandvekar <[email protected]>
lsm5
force-pushed
the
podman6-no-slirp
branch
from
b0d486b to
65538e9
Compare
Signed-off-by: Lokesh Mandvekar <[email protected]>
When NetMode.IsPasta() is true but pastaResult is nil (which can happen during container setup failures or in certain edge cases), accessing c.pastaResult.IPAddresses causes a panic. Add a nil check for c.pastaResult before accessing its fields, matching the pattern used elsewhere in the codebase. Fixes rootless test failures in PR containers#27338. Signed-off-by: Lokesh Mandvekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR introduce a user-facing change?